Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Campaign Creation: Add coupon banner to the top of the page #2499

Open
3 tasks done
Tracked by #2459
joemcgill opened this issue Aug 6, 2024 · 10 comments · Fixed by #2558
Open
3 tasks done
Tracked by #2459

Campaign Creation: Add coupon banner to the top of the page #2499

joemcgill opened this issue Aug 6, 2024 · 10 comments · Fixed by #2558

Comments

@joemcgill
Copy link
Collaborator

joemcgill commented Aug 6, 2024

Part of #2459

Image

In order to bring more prominence to the $500 ads credit that is available for new accounts, we'll make the offer more prominent on the campaign creation step of the onboarding flow.

Acceptance Criteria

  • When an Ads account is eligible for a free Ads credit, the FreeAdCredit component will be displayed at the bottom of the PaidAdsFeatureSection Card in the Campaign Creation step of the onboarding flow.
  • When an Ads account is not eligible, the component will not be shown.
  • The existing text in that card that shows the $500 credit is removed.

Implementation Brief

A component for this banner is already part of the SetupAccounts step for the ads setup stepper (js/src/setup-ads/ads-stepper/setup-accounts/index.js). This component can be moved to the top-level js/src/components directory and used in both the current SetupAccounts component and imported into the SetupPaidAds component in js/src/setup-mc/setup-stepper/setup-paid-ads/setup-paid-ads.js. This should use the same useFreeAdCredit() hook to determine whether it is displayed.

Test Coverage

  1. E2E tests in tests/e2e/specs/setup-mc/step-4-complete-campaign.test.js should be updated to add a test that confirms the banner is shown
  2. Ensure E2E tests for the ads stepper are updated if needed.
@joemcgill joemcgill changed the title Add coupon banner to the top of the page Campaign Creation: Add coupon banner to the top of the page Aug 6, 2024
@joemcgill joemcgill self-assigned this Aug 6, 2024
@joemcgill joemcgill added the needs design The issue requires design input/work from a designer. label Aug 7, 2024
@joemcgill
Copy link
Collaborator Author

@fblascogarma:

#2459 includes a prototype that shows the banner across the entire top of the page. For consistency, can we show this within the StepContent component above the PaidAdsFeaturesSection component?

Would you be ok with us taking this approach rather than needing to create updated designs for this issue?

@fblascogarma
Copy link
Collaborator

@joemcgill which one is the StepContent and PaidAdsFeaturesSection? Is the StepContent the progression tracker that shows the steps of the onboarding flow? And is the PaidAdsFeaturesSection the card with title "Drive more sales blablalba..."?

@joemcgill
Copy link
Collaborator Author

@fblascogarma the StepContent component is what shows the content for a specific step and the PaidAdsFeatureSection is the top section of that page this is shown currently with the information about the PMax campaign in the left column and the "Drive more sales" card in the right column. Here's a quick example of what I'm proposing so it's easier to visualize.

image

@fblascogarma
Copy link
Collaborator

Thank you for visualizing your proposal, @joemcgill ! I'm okay with it. But should Michael the designer validate it just in case?

@joemcgill
Copy link
Collaborator Author

@michaeleleder is going to look into this and provide some UX feedback based on the usage of this component in the Woo design system.

@michaeleleder
Copy link
Collaborator

@joemcgill Seems like nowhere it explicitly says the Inline Notice component has to be on certain background so if making any changes means significant effort, technically it doesn't break any rule and doesn't seem to cause any accessibility issues.

That said, it is clear that this component is always used on a white background in both the design systems and WordPress Developer Resources (except for the white one, which is used on a grey background), so if we want to keep it consistent, we should place it on a white background.

Image

Most logical adjustment would be adding the component to the white card, also because the card already mentiones the $500 credit making this duplicite. That said, I'm not aware or all the potential implications, for example how does it affect the layout when the component isn't shown (when an Ads account is not eligible).

@joemcgill
Copy link
Collaborator Author

Thanks @michaeleleder this makes sense to me. Here's a quick example of what I think that would look like.

Image

@joemcgill joemcgill removed the needs design The issue requires design input/work from a designer. label Aug 16, 2024
@asvinb asvinb self-assigned this Aug 21, 2024
@asvinb asvinb assigned joemcgill and unassigned asvinb Aug 22, 2024
@joemcgill
Copy link
Collaborator Author

For posterity, the previous design mockup above was approved via a Slack conversation.

@joemcgill joemcgill assigned asvinb and unassigned joemcgill Aug 26, 2024
@asvinb asvinb assigned joemcgill and unassigned asvinb Aug 27, 2024
@joemcgill
Copy link
Collaborator Author

@ankitguptaindia this is ready for QA. Note that the original requirements are a bit vague, as they read "When an Ads account is eligible for a free Ads credit..." However, what the requirements are for eligibility was not clearly defined. Currently, the $500 credit text is always shown when you get to the fourth step of onboarding based on a Google Ads account being connected. We're using the same logic to display this banner instead, which is the expected behavior that should be tested.

@ankitguptaindia ankitguptaindia removed their assignment Aug 29, 2024
@joemcgill joemcgill assigned asvinb and unassigned eason9487 Sep 4, 2024
@joemcgill
Copy link
Collaborator Author

@asvinb some additional feedback to address here when you have a chance.

@eclarke1 eclarke1 removed the Rollover label Sep 5, 2024
@asvinb asvinb assigned joemcgill and unassigned asvinb Sep 5, 2024
@joemcgill joemcgill assigned asvinb and unassigned joemcgill Sep 9, 2024
@asvinb asvinb assigned joemcgill and asvinb and unassigned asvinb and joemcgill Sep 10, 2024
@joemcgill joemcgill self-assigned this Sep 16, 2024
@asvinb asvinb assigned eason9487 and unassigned asvinb and joemcgill Sep 18, 2024
@eason9487 eason9487 removed their assignment Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants