Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Paid Campaigns] - Leaving the page doesn't show alert prompt after editing changes #2090

Open
puntope opened this issue Sep 8, 2023 · 0 comments
Labels
type: bug The issue is a confirmed bug.

Comments

@puntope
Copy link
Contributor

puntope commented Sep 8, 2023

Describe the bug:

Related to #1640

In Free Listings, when we change the options and we attempt to leave the page, a prompt appears alerting the user about the changes not being saved. However, in Paid Ads Campaigns this is not working.

Screen.Recording.2023-09-08.at.13.35.19.mov

Steps to reproduce:

  1. Go to Edit Paid Campaign
  2. Change something, for example the DAILY AVERAGE COST input
  3. Click on the back button on the top left
  4. NO Prompt is shown

Expected behavior:

A prompt is shown as we do in Free Listings

Actual behavior:

A prompt is NOT shown.

Additional details:

Several PRs and rounds of mods were happening in regard this issue:

#1670
#2077
#1580

@puntope puntope changed the title [Paid Campaigns] Leaving the page doesn't show alert prompt after editing changes [Paid Campaigns] - Leaving the page doesn't show alert prompt after editing changes Sep 8, 2023
@puntope puntope added the type: bug The issue is a confirmed bug. label Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug The issue is a confirmed bug.
Projects
None yet
Development

No branches or pull requests

1 participant