Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: honor getViteConfig inlineAstroConfig.logLevel setting #12358

Merged
merged 5 commits into from
Nov 4, 2024

Conversation

spacedawwwg
Copy link
Contributor

Changes

Use inlineAstroConfig.logLevel if passed to getViteConfig

Testing

Tested locally using fork.

Docs

There are no additional docs as this change fixes what should already happen.

Copy link

changeset-bot bot commented Nov 2, 2024

🦋 Changeset detected

Latest commit: e726013

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Nov 2, 2024
packages/astro/src/config/index.ts Outdated Show resolved Hide resolved
.changeset/cuddly-feet-float.md Outdated Show resolved Hide resolved
@spacedawwwg
Copy link
Contributor Author

@bluwy changes made 👍🏻

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ematipico ematipico merged commit 7680349 into withastro:main Nov 4, 2024
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Nov 4, 2024
@spacedawwwg spacedawwwg deleted the patch-1 branch November 4, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants