Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix watchfile multiple dev server restart #12353

Merged

Conversation

hippotastic
Copy link
Contributor

Changes

  • Fixes an issue in dev server watch file handling that could cause multiple restarts for a single file change.
  • This issue was triggered by changes to watched files added by integrations through Astro's addWatchFile API. Our override for the Vite restart handler was missing a check for the container's restartInFlight flag and caused multiple overlapping restarts.
  • This also fixes the repeated Port 27969 is in use, trying another one... message that appeared in this case.

Testing

  • Tested locally by running Astro's test suite and on a Starlight site.

Docs

  • Just a bugfix.

Copy link

changeset-bot bot commented Nov 2, 2024

🦋 Changeset detected

Latest commit: e9cbd4d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Nov 2, 2024
@bluwy bluwy merged commit 35795a1 into withastro:main Nov 4, 2024
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Nov 1, 2024
@hippotastic hippotastic deleted the fix-watchfile-multiple-dev-server-restart branch November 4, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants