Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors with BS4 #77

Open
atstockland opened this issue Jul 3, 2016 · 4 comments
Open

Errors with BS4 #77

atstockland opened this issue Jul 3, 2016 · 4 comments

Comments

@atstockland
Copy link

atstockland commented Jul 3, 2016

After upgrading to bootstap 4 I am working through a few new issues. When I click on the x-editable link the popup appears, but with no content. And, the following error appears in the console. Have you experienced this, will there be a BS4 version of this gem?

TypeError: undefined is not an object (evaluating 'this.tip().addClass')

This error occurs when using editable/bootstrap-editable. If I use 'jqueryui-editable' I get a different error: TypeError: undefined is not an object (evaluating 'this.container()._off')

Environment: Rails 5.0.0, x-editable-rails version 1.5.5, jquery-ui-rails -v 5.0.5, jquery-rails -v 4.1.1. Bootstrap -v 4.0.0.alpha3.

thanks

@jirikolarik
Copy link
Member

X-editable is not under active development and bootstrap 4 is still in alpha stage. Currently it supports bootstrap v2 and v3 and honestly I don't expect it is gonna change. Sorry to say

@jirikolarik
Copy link
Member

Please refer to x-editable in regards to bootstrap 4

@apavlyut
Copy link

@atstockland this fix works for me vitalets/x-editable#950.

@EdnaldoNeimeg
Copy link

Yeah, I did it ;)

I made some improvements and now it's working perfectly
(you'll might need to change your CSS)
https://gist.github.com/EdnaldoNeimeg/c7279ccade22d590ad89f4e0fe456742

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants