Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suspicious source/tests changed results #7

Open
sobolevn opened this issue Apr 3, 2019 · 2 comments
Open

Suspicious source/tests changed results #7

sobolevn opened this issue Apr 3, 2019 · 2 comments

Comments

@sobolevn
Copy link
Member

sobolevn commented Apr 3, 2019

I am pretty sure that I have seen multiple warnings like The source code was changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes. that were raised by mistake.

Needs further investigation.
@sobolevn
Copy link
Member Author

sobolevn commented Apr 3, 2019

Source: https://github.com/wemake-services/kira-review/blob/master/danger-platforms/django/Dangerfile#L18-L23 and https://github.com/wemake-services/kira-review/blob/master/danger-platforms/elixir/Dangerfile#L12-L17

@sobolevn
Copy link
Member Author

sobolevn commented May 5, 2019

Nuxt has this too:

The source code was changed, but the tests remained unmodified.
  Consider updating or adding to the tests to match the library changes.

I am 100% tests were added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sobolevn