Migrate from pkg_resources to importlib.metadata #249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
requested changes
May 4, 2022
Codecov Report
@@ Coverage Diff @@
## master #249 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 42 43 +1
Branches 8 8
=========================================
+ Hits 42 43 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Bump python requirement to 3.7 since 3.6 is EOL Fixes #248
|
Rebased to fix merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates from deprecated
pkg_resourcesto the stdlibimportlib.metadata. Python version is also updated to minimum 3.7 as 3.6 is now EOL.I'm not sure why flake8 version in poetry.lock was lowered by poetry.
I ran
poetry remove setuptoolsandpoetry add --python "<3.8" importlib_metadatato swap the dependency. I am running poetry on python3.10.Fixes #248