Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out why the StringToBool test is so slow #27

Closed
edsko opened this issue Mar 11, 2023 · 2 comments
Closed

Figure out why the StringToBool test is so slow #27

edsko opened this issue Mar 11, 2023 · 2 comments

Comments

@edsko
Copy link
Collaborator

edsko commented Mar 11, 2023

It turns out, the variant function is called more than 3 million times in this test; that explains why #26 had such a dramatic impact. It's however not entirely clear to me why it's called quite that often. Would be good to investigate, as it might reduce the need to solve #25 .

@edsko
Copy link
Collaborator Author

edsko commented Mar 11, 2023

Actually, I think I might have counted recursive calls here too, so this might be a red herring.

@edsko
Copy link
Collaborator Author

edsko commented Mar 11, 2023

Yeah, re-counted. Only about 38k times, which seems somewhat reasonable, given the long strings, characters being used, and the fact that we keep re-executing the entire tests (which is what #25 is about).

@edsko edsko closed this as completed Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant