Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reply to comments #93

Open
weiran opened this issue May 4, 2019 · 7 comments
Open

Reply to comments #93

weiran opened this issue May 4, 2019 · 7 comments
Assignees
Milestone

Comments

@weiran
Copy link
Owner

weiran commented May 4, 2019

No description provided.

@weiran weiran added this to the 4.0 milestone May 4, 2019
@weiran weiran self-assigned this May 4, 2019
@robbiet480 robbiet480 mentioned this issue May 17, 2019
@weiran weiran modified the milestones: 4.0, 4.1 Jun 15, 2019
@weiran weiran modified the milestones: 4.2, 5.0 Apr 19, 2020
@mmangione
Copy link

I love this app. Happy to jump in and help out. Where does this feature stand?

@PerpetualCreativity
Copy link

I think we first need to think of how we want to trigger this action. Swiping and tapping on comments already has a meaning. Should we bind adding a comment to a long-press action?

@jalxp
Copy link
Contributor

jalxp commented May 6, 2022

@PerpetualCreativity I've seen more than one action on each swipe around for stuff like this. Take as an example the Apollo app for reddit, which looks pretty smooth. Nowadays most users expect a contextual menu on long presses as that's what natively happens on iOS.
Unless you are suggestion adding this exact menu where one of the entries is the reply! 😄

@PerpetualCreativity
Copy link

@jalxp I completely forgot about those kinds of swipe actions, and was talking about the contextual menu. (Another example of multiple actions on a swipe is the Mail app with default settings, by the way.) I think your idea, of adding reply as an additional swipe action, is the best solution.

@ktechmidas
Copy link

@PerpetualCreativity As a user who didn’t know we couldn’t reply yet here’s what I did in order to try to find it

  • swipe left
  • Swipe right
  • Long press

@ErikThiart
Copy link

Why not let user long press on the comment they want to reply to.

Easy peasy

Long Press, menu pops up, Reply

Tap reply,

Write reply

@wesley-harding
Copy link

Being a bit blunt. This thread has become a bit of bike shedding; focusing on the gesture to initiate reply rather than how we make it work technically. Wiring up the trigger action is the the easiest part of this feature.

I really enjoy this app, but without comments I'll end up using another app.

I'm guessing we need to do the following to make this work:

  • Codify the comment submit HTTP request

  • Create a "submit comment" screen

  • Create a "comment submitted" screen or other UX indicator.

Bonus

  • Insert the newly submitted comment into the comment tree. Either a full refresh or a selective insert.

  • Handle edit

  • Handle common errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants