-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AvatarMIMELimitService limits mime types for all uploads, but only for the browser-uploader #59
Comments
Good catch! As we already discussed: This plugin was branched out of a larger plugin. There it was meant to restrict all uploads. And yes, I really want to leave this one in. Photographers uploading 30MB avatars should not be allowed. |
Okay but then we really need to find a clean way to limit this to only the avatar upload. |
Oh now that I looked into this some more actually it affects all uploads, but only for the Browser Uploader. When using the Multi-Uploader (plupload) it doesn't do anything ever because it is limited to the screen-bases of |
I'm not sure how that came to be. Maybe first it was restricted to only the profile page and later was extended to make the multi-uploader work not considering that it now affects all uploads.
So if we really want to restrict the upload here we need to make sure it only happens for avatar uploads which will be hard for async uploads. This is the same problem we'd have in #49
Otherwise we just get rid of this and consider it out of scope for the plugin.
The text was updated successfully, but these errors were encountered: