New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistency: TransformerBaseClassification.embed() returns np.float32 while SetFitClassification returns np.float64 #48

Open

chschroeder opened this issue Oct 13, 2023 · 0 comments

Labels

good first issue improvement

Milestone

small-text-2.0.0

Contributor

chschroeder commented Oct 13, 2023 •

edited

Loading

Desired Solution

Clearly specify the EmbeddingMixin and make all implementations behave consistently. All returned embeddings should be np.float32.

This fits in well with the ongoing typing efforts.

chschroeder added the improvement label

chschroeder added this to the small-text-2.0.0 milestone

chschroeder added the good first issue label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment