Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle buffers created with MapRead #29

Open
greggman opened this issue Jan 20, 2023 · 3 comments
Open

Handle buffers created with MapRead #29

greggman opened this issue Jan 20, 2023 · 3 comments

Comments

@greggman
Copy link
Collaborator

Buffer usages (BufferUsage::(MapRead|CopySrc|CopyDst)) is invalid. If a buffer usage contains BufferUsage::MapRead the only other allowed usage is BufferUsage::CopyDst.

@greggman greggman changed the title How to handle buffers created with MapRead Handle buffers created with MapRead Jan 20, 2023
@Kangz
Copy link
Collaborator

Kangz commented Jan 22, 2023

I'm not sure what this issue is about, but in general I don't think that we should support replays of applications with validation errors, it will be difficult to shield against error propagation in readbacks etc in that case.

@greggman
Copy link
Collaborator Author

The application doesn't have validation errors. The debugger is adding flags

@Kangz
Copy link
Collaborator

Kangz commented Jan 23, 2023

Ah ok, so this issue is about mappable buffers not being special cased in the capture code, so flags are added and there's a validation error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants