-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling creation and destruction #28
Comments
The trace should be correctly destroying resources no? That's why there is the WeakMap too. |
The replay does not. |
The replay needs to keep the resources alive otherwise it's not possible to go back. Do you have another suggestion? |
The trace should arguably record creation and destruction that happens during the trace. So there's the pool of objects that existed before the trace, and then objects added and destroyed during the trace. At replay, create the initial pool then create/destroy the rest in playback. |
IIUC trace/replay never destroys a resource. That seems problematic. I can imagine creating a temp 2gig buffer, then destroying it, then creating another, then destroying it, etc....... If replay never destroys resources it will run out of memory.
The text was updated successfully, but these errors were encountered: