Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service fails if manifest for the version of VS Code is not available #56

Open
mattseddon opened this issue Dec 14, 2022 · 2 comments
Open
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@mattseddon
Copy link
Contributor

I've just spent a couple of hours chasing around an issue with this service.

It started failing in our pipeline with the error SevereServiceError: Couldn't set up Chromedriver Couldn't fetch Chromedriver version: Unexpected token : in JSON at position 3

We test against stable (which got updated today). Turns out that the manifest for 1.74.1 (https://raw.githubusercontent.com/microsoft/vscode/1.74.1/cgmanifest.json) has not been made available yet.

Would it be possible to fallback to main (insiders) with an appropriate message under these circumstances?

cc @christian-bromann

@christian-bromann christian-bromann added bug Something isn't working help wanted Extra attention is needed labels Dec 14, 2022
@redmundas
Copy link

having the same issue for vscode 1.82.2.
and I had to dig through source to figure out which version doesn't have the manifest file.
so it would be helpful that error message would say which version is broken at least.

@seanpoulter
Copy link
Contributor

I have a proposal. Since you've both mentioned the problem for patch releases for 1.74.1 and 1.82.2, I propose we:

  • Fallback to the previous patch release and warn that the url was not available (ex. when 1.74.1 404s, try 1.74.0)
  • Otherwise, throw and improve the error message to include the VS Code version, URL, HTTP status, and a link to this issue.

I believe that'd help and collect feedback if we've solved the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants