Skip to content
This repository has been archived by the owner on Dec 18, 2019. It is now read-only.

Viewport Screenshots for Default Workflow #147

Open
tf opened this issue Mar 20, 2016 · 0 comments
Open

Viewport Screenshots for Default Workflow #147

tf opened this issue Mar 20, 2016 · 0 comments

Comments

@tf
Copy link

tf commented Mar 20, 2016

Hi,

first let me say, that this is an great library and which let me get to really good results really quickly.

While testing a website built with absolute positions, I ran into the issue described in #141. Looking through the code, I found that there already was a way to make viewport screenshots rather than document screenshots, which was exactly what I wanted. Still, the default workflow relies on makeScreenshot which only supports saveDocumentScreenshot.

So I am wondering if I should prepare a PR adding an option for the webdrivercss call, which makes the default workflow use saveViewportScreenshot. Or is there already another way or even a reason not to do it at all?

Best,
Tim

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant