Skip to content
This repository has been archived by the owner on Sep 7, 2022. It is now read-only.

Reactify not working in latest Chrome version #58

Open
kentendo opened this issue Dec 20, 2016 · 6 comments
Open

Reactify not working in latest Chrome version #58

kentendo opened this issue Dec 20, 2016 · 6 comments
Assignees

Comments

@kentendo
Copy link

@treshugart
Reactified component is rendering in Firefox, but not in latest Chrome (55.0.2883.95).
Component gets inserted inserted into DOM but is never upgraded and never renders itself.

See codepen below...
http://codepen.io/kentendo/pen/BQMEbe?editors=1010

@kentendo
Copy link
Author

I only see this happening in Chrome version 55.*
Works in 56.

@treshugart
Copy link
Contributor

@kentendo do you have a reproduction of this? If you can write a failing test for this, that would be awesome :). Currently tests pass in 55.

@treshugart treshugart self-assigned this Dec 21, 2016
@kentendo
Copy link
Author

kentendo commented Dec 21, 2016

I started on a test, but looked at the other tests in here and noticed they are still using the v0 API. The issue I'm seeing is more v1 specific, where the lifecycle hooks ( onConnectedCallback, etc ) are never getting called. Any ideas?

@treshugart
Copy link
Contributor

You're right. We should update the tests, for sure. I raised #59 for this. I don't have much time to do this for the next week or so. Would you have time to submit a PR for it? I understand if not.

@kentendo
Copy link
Author

I'll give it a shot...

@kentendo
Copy link
Author

kentendo commented Dec 22, 2016

I've made some good progress on #59, but I'm having issues with the event tests in chrome...
https://github.com/kentendo/react-integration

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants