Skip to content
This repository has been archived by the owner on Sep 7, 2022. It is now read-only.

Context doesn't get passed through #11

Open
jpnelson opened this issue May 11, 2016 · 5 comments
Open

Context doesn't get passed through #11

jpnelson opened this issue May 11, 2016 · 5 comments

Comments

@jpnelson
Copy link
Contributor

Breaks for things such as https://github.com/yahoo/react-intl

@jpnelson jpnelson self-assigned this May 11, 2016
@marcodejongh
Copy link

marcodejongh commented Jun 20, 2016

😢

@jpnelson
Copy link
Contributor Author

@marcodejongh There's a workaround for the portals method that I spiked, but it's a bit hacky – React doesn't want to be able to expose context to anything except through direct dependency, so you need to get the internal data.

@treshugart is working on a pull request that will not use portals at all – it will rely on our shadow DOM polyfill. This will be fine as long as we don't move entire elements in the DOM, which is the plan for future components.

@treshugart
Copy link
Contributor

As far as react is concerned, we can still move entire elements, so long as it's part of the shadow DOM. Though, if we did that, then it's no longer part of the Shadow DOM and hard for us to control it's rendering so I doubt we'll do that at all in the future.

@treshugart
Copy link
Contributor

treshugart commented Jun 20, 2016

Isn't context an experimental feature, though? From Reacts website:

Context is an advanced and experimental feature. The API is likely to change in future releases.

@treshugart
Copy link
Contributor

This may be fixed by #18 but we should write a test for it to be sure.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants