-
Notifications
You must be signed in to change notification settings - Fork 31
Context doesn't get passed through #11
Comments
😢 |
@marcodejongh There's a workaround for the portals method that I spiked, but it's a bit hacky – React doesn't want to be able to expose context to anything except through direct dependency, so you need to get the internal data. @treshugart is working on a pull request that will not use portals at all – it will rely on our shadow DOM polyfill. This will be fine as long as we don't move entire elements in the DOM, which is the plan for future components. |
As far as react is concerned, we can still move entire elements, so long as it's part of the shadow DOM. Though, if we did that, then it's no longer part of the Shadow DOM and hard for us to control it's rendering so I doubt we'll do that at all in the future. |
Isn't context an experimental feature, though? From Reacts website:
|
This may be fixed by #18 but we should write a test for it to be sure. |
Breaks for things such as https://github.com/yahoo/react-intl
The text was updated successfully, but these errors were encountered: