Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clearly define Path #59

Open
jogibear9988 opened this issue May 24, 2021 · 1 comment
Open

clearly define Path #59

jogibear9988 opened this issue May 24, 2021 · 1 comment

Comments

@jogibear9988
Copy link
Contributor

The path property here:

is? relative to this file or relative to the package.json? has the extension within?

@steren
Copy link

steren commented Dec 27, 2021

With the example added to the README (#91), I am a bit confused about what path should contain:

it seems that the example module is at my-project/my-element.js and the manifest at my-project/custom-elements.json, path it set to "path": "my-project/my-element.js".

I found this surprising, as I was expecting path to use a relative path from where the manifest was located. Since it is in the same folder as the module, I was expecting "path": "my-element.js" instead.

Can you check the example and provide more guidance around path?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants