-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TTL doesn't seem to be honored #284
Comments
Which version of Chrome? |
Version 58.0.3029.110 (64-bit) |
could you please file this on crbug.com |
@sathio did you file a bug on crbug.com? Can you link it here? |
Hi, I will file an issue today, but I'm not yet convinced this is on chrome/chromium side. |
You can add some logging here if you want: https://github.com/web-push-libs/web-push/blob/master/src/web-push-lib.js#L265. |
Here's a detailed response, HEADERS are from the web-push-lib.js file as you've suggested.
This header here suggests that maybe there's a TTL of 30 days? |
The TTL is the TTL header, so it's 7200 in your request. |
@sathio did you file a bug on crbug.com? |
Hi. Any news for this? |
Not yet |
hey all, i'm also seeing issues with this! have you guys got any example scenarios of when this is failing? did anyone file a bug yet @sathio ?? if not, i will! |
I am also seeing issues with the TTL across different browsers (Chrome 76/75, Firefox 67/66) now. |
I contacted the FCM team as well regarding this issue, FCM Support team has acknowledged that they are aware of this issue and are working on a fix for it. And so I think we can close this ticket. More details here |
In reference to #491 which is a duplicate of this, I wish to point that the fact that a value of ZERO for TTL in options object not being honoured is due to this line of code. This if condition will always fail for a ZERO TTL and fallback to the DEFAULT_TTL of 4 weeks. Line 158 in 7bda588
Request you to explain if this is expected behaviour. |
Oh, thanks for noticing that, so #491 is not a duplicate then. |
Setup
Operating System: Linux
Node Version: v6.2.2
web-push Version: ^3.2.2
Browser
Problem
TTL is not honored, if I set 7200 seconds it is still shown the next morning when I fire up the browser
Expected
Notifications should expire after TTL seconds
Features Used
Example / Reproduce Case
The text was updated successfully, but these errors were encountered: