Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to set the aud for localhost #157

Open
George3d6 opened this issue Dec 28, 2023 · 2 comments
Open

How to set the aud for localhost #157

George3d6 opened this issue Dec 28, 2023 · 2 comments

Comments

@George3d6
Copy link

Chrome/Chromium require the aud parameter in the vapid claims (403 error asking for it is returned otherwise).

However just setting this to http://localhost:port doesn't seem to work (it's not recognized as a valid aud)

@George3d6
Copy link
Author

Ups, I was mistaken here, the aud is supposed to be the actual push service origin (e.g. https://fcm.googleapis.com for chromium`) -- in this case, should this parameter be automatically extracted from the subcription info being passed?

Could make a PR with this fix if so.

@jrconlin
Copy link
Member

we should be extracting the aud from the vapid claims, so long as it's not present (e.g. it's None not an empty string). Is that not working for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants