Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc_logging interceptor logs full request bodies as ASCII byte arrays, not strings #90

Open
cboggs opened this issue Mar 12, 2018 · 0 comments

Comments

@cboggs
Copy link
Contributor

cboggs commented Mar 12, 2018

A prime example of this is the behavior seen on a failed push to an ingester where the entire push body is logged as a frighteningly large byte array.

Reference #89 and cortexproject/cortex#709 for a more thorough conversation on the details.

The above-referenced weaveworks/common PR avoids this issue by simply allowing a per-service configuration that truncates these logs, omitting the request body.

It might be better, though, to retain the request bodies and simply log them as the strings they are, rather than their ASCII code representation.

yeya24 pushed a commit to yeya24/common that referenced this issue Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant