-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP Middleware Error Logging: Vision on StatusBadGateway/ServiceUnavailable #192
Comments
Background is here: cortexproject/cortex#810, http://github.com/weaveworks/common/pull/84 I would be ok with sampling the messages (we have You could also sample after the line hits the logfile? |
Thanks for the background. As suspected those two error codes were just overwhelming the logs and so they got removed. It sounds like you're ok with the general idea so I will submit a PR and we can discuss details there.
|
The http logging middleware splits out different request results and logs them as either debug or warn. Generally errors are logged as warn and successes are logged as debug.
common/middleware/logging.go
Lines 56 to 64 in 4b18475
We need to log the below error conditions that are currently being logged as debug. Unfortunately, due to volume, we can't turn on debug logging.
My guess is that these two statuses are logged at a debug level due to volume if the backend is unavailable. We would like to log these failures at a higher level than debug, but also recognize that the volume would be too great to log if a backend is down.
The change we'd like to make:
http.StatusBadGateway
andhttp.StatusServiceUnavailable
to be logged at a Warn level with the other errorsThoughts?
If this (or something similar) is acceptable I'd be glad to PR it.
@bboreham
The text was updated successfully, but these errors were encountered: