-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uses unlicensed opentracing-contrib/go-grpc #160
Comments
Thanks for raising this. I'll try again to make contact with its maintainers. |
The upstream issue is now fixed. Can we update our dep? |
yeya24
pushed a commit
to yeya24/common
that referenced
this issue
Jun 12, 2024
…#160) Signed-off-by: tariqibrahim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
server/server.go imports github.com/opentracing-contrib/go-grpc
This repo doesn't have a license (opentracing-contrib/go-grpc#3), so this makes weaveworks/common unusable for us.
go-grpc looks trivial, so if getting it licensed is somehow hard, it would probably not take very long to rewrite...
The text was updated successfully, but these errors were encountered: