Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong format for the order parameter #11

Open
Aedial opened this issue Jun 30, 2022 · 0 comments
Open

Wrong format for the order parameter #11

Aedial opened this issue Jun 30, 2022 · 0 comments

Comments

@Aedial
Copy link

Aedial commented Jun 30, 2022

When using a scenario (exported from the website without any modification), the test throws the error "Error loading scenario: Logit ID is not a string or an uint!". This error happens because the code expects settings.parameters.order to be of the format "array of (string or int)" : ["typical_p", "tfs", "top_a", "temperature", "top_p", "top_k"]
But the format actually exported by the website is a bit more complex :

[
  {
    "id": "typical_p",
    "enabled": true
  },
  {
    "id": "tfs",
    "enabled": true
  },
  {
    "id": "top_a",
    "enabled": true
  },
  {
    "id": "temperature",
    "enabled": true
  },
  {
    "id": "top_p",
    "enabled": false
  },
  {
    "id": "top_k",
    "enabled": false
  }
]

The function taking care of this is "func (ids *LogitProcessorIDs) UnmarshalJSON(buf []byte) error" in api.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant