Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Username and password should be URL encoded #18

Open
watou opened this issue Mar 28, 2013 · 2 comments
Open

Username and password should be URL encoded #18

watou opened this issue Mar 28, 2013 · 2 comments
Assignees
@watou
Labels
bug

Comments

@watou
Copy link
Owner

watou commented Mar 28, 2013

One user had to remove the & from his password in order for the plugin to login.
@ghost ghost assigned watou Mar 28, 2013
@watou
Copy link
Owner Author

watou commented Mar 28, 2013

Either urlcode.encodetable isn't working properly, or the password should not in fact be encoded. Huh.

@watou
Copy link
Owner Author

watou commented Apr 17, 2013

I think urlcode.encodetable is probably being overly aggressive. Just lift stringify from ecobee plugin code and test that instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@watou watou

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@watou