Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Wasmi execution profiling infrastructure #974

Closed
wants to merge 20 commits into from

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Apr 2, 2024

Closes #973.

  • Add Wasmi profiling macros.
  • Apply Wasmi profiling macros to Wasmi bytecode enum.
    • Requires the profiling crate feature.
  • Adjust the Wasmi executor to use the new Wasmi profiling data.
    • Requires the profiling crate feature.
  • Add support for Wasmi profiling data output to Wasmi CLI.
    • Requires the profiling crate feature.
  • Add support for returning Wasmi profiling data to Wasmi library.
    • Requires the profiling crate feature.

This should provide better and more versatile information than a flamegraph.

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 1.49254% with 66 lines in your changes are missing coverage. Please review.

Project coverage is 81.65%. Comparing base (e884ed2) to head (698c5ec).

Files Patch % Lines
crates/profiling/macro/src/lib.rs 2.43% 40 Missing ⚠️
crates/profiling/src/lib.rs 0.00% 20 Missing ⚠️
crates/profiling/macro/src/utils.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #974      +/-   ##
==========================================
- Coverage   81.87%   81.65%   -0.23%     
==========================================
  Files         260      263       +3     
  Lines       23904    23971      +67     
==========================================
+ Hits        19572    19573       +1     
- Misses       4332     4398      +66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop
Copy link
Member Author

Closed for now since there is no longer any major reason to have this implemented. We might re-open this PR later or have another attempt with another PR if we find this to be required again.

@Robbepop Robbepop closed this Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Wasmi execution profiling
1 participant