Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fuzzing CI seems to not cache the corpus #1117

Open
Robbepop opened this issue Jul 7, 2024 · 2 comments
Open

CI: fuzzing CI seems to not cache the corpus #1117

Robbepop opened this issue Jul 7, 2024 · 2 comments
Labels
bug Something isn't working ci CI work item help wanted Extra attention is needed

Comments

@Robbepop
Copy link
Member

Robbepop commented Jul 7, 2024

It seems that even with the recent refactoring and improvements to the CI's caching behavior the fuzzing CI jobs still do not properly store and re-store their fuzzing corpuses and thus our fuzzing CI is practically useless.

Without the corpus in the cache the fuzzing CI has no memory of the past fuzzing artifacts and thus cannot built on-top of past successes and findings.

@Robbepop Robbepop added bug Something isn't working ci CI work item help wanted Extra attention is needed labels Jul 7, 2024
@Robbepop
Copy link
Member Author

@gtrepta @Scott-Guest Just to be sure: has this been fixed in #1234 ?

@gtrepta
Copy link
Contributor

gtrepta commented Oct 21, 2024

No, that PR didn't totally fix it. I think two issues here are that each job is sharing the same cache, and the corpus folder isn't considered when deciding to update the cache.

Given how much smaller the corpus is compared to the rust cache, I think it can be put into a separate caching step. Something like this:

- name: Fuzz corpus caching
  uses: actions/cache@v4
  with:
    path: ${{ github.workspace }}/hfuzz_workspace
    key: fuzz-${{ matrix.fuzz_target }}-${{ github.run_id }}
    restore-keys: |
      fuzz-${{ matrix.fuzz_target }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci CI work item help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants