Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate bindings for brave-intl/wasm-thumbnail #44

Open
4 of 5 tasks
Michael-F-Bryan opened this issue Oct 5, 2022 · 2 comments
Open
4 of 5 tasks

Generate bindings for brave-intl/wasm-thumbnail #44

Michael-F-Bryan opened this issue Oct 5, 2022 · 2 comments

Comments

@Michael-F-Bryan
Copy link
Contributor

Michael-F-Bryan commented Oct 5, 2022 •
edited
Loading

It'd be cool if we can migrate brave-intl/wasm-thumbnail over to wit-pack.

The implementation is available in the wit-pack branch of wasmerio/wasm-thumbnail.

  • Switch the underlying crate over to wit-bindgen
  • Add examples for using the Python and JavaScript bindings
  • Add instructions for building/publishing bindings
  • Publish to wapm.dev (see Michael-F-Bryan/wasm-thumbnail)
  • Make a PR upstream
@Michael-F-Bryan Michael-F-Bryan added this to the More Packages milestone Oct 5, 2022
@Michael-F-Bryan
Copy link
Contributor Author

Something I should mention is that they've got Ruby bindings at the moment. However, wit-bindgen doesn't support Ruby at the moment, and that may be an issue if we want adoption upstream.

@Michael-F-Bryan
Copy link
Contributor Author

This is also blocked on https://github.com/wasmerio/wapm.io-backend/issues/240. To write the example code I ended up using a local version of the generated bindings.

@Michael-F-Bryan Michael-F-Bryan removed this from the More Packages milestone Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Michael-F-Bryan