Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Display call parameters in the callstack table #143

Closed
barabanovro opened this issue Apr 11, 2024 · 4 comments · Fixed by #147
Closed

feat: Display call parameters in the callstack table #143

barabanovro opened this issue Apr 11, 2024 · 4 comments · Fixed by #147
Assignees
Labels

Comments

@barabanovro
Copy link
Contributor

The run API endpoint has been updated to return parameters within the callstack entries. These parameters can be found at callstack[execution_step][call_index].params.

Required Changes:

  • Introduce a new column titled PARAMETERS in the callstack table.
  • Display parameter values in a comma-separated row within this column.
  • Display the parameter value as an array in square brackets if it consists of more than one element.
  • Implement a tooltip for each parameter that shows its type_name.
  • Adjust and reduce the gaps between other columns to accommodate the new Parameters column and optimize space use.

Parameters example:

[
   {
      "type_name":"RangeCheck",
      "value":[
         828
      ]
   },
   {
      "type_name":"GasBuiltin",
      "value":[
         9999999977109
      ]
   },
   {
      "type_name":"core::integer::u256",
      "value":[
         3,
         0
      ]
   },
   {
      "type_name":"core::integer::u256",
      "value":[
         5,
         0
      ]
   },
   {
      "type_name":"core::integer::u256",
      "value":[
         7,
         0
      ]
   }
]

We expect to see comma-separated Parameters row:
828, 9999999977109, [3, 0], [5, 0], [7, 0]

@jaipaljadeja
Copy link
Contributor

jaipaljadeja commented Apr 11, 2024

hey i would like to do this, i recently did the virtualization changes, so i know where to add the column and rest.

@melnikga
Copy link
Contributor

Can I take this?

@BlackStarkGoku
Copy link
Contributor

Hi, I am a frontend software engineer that recently discovered starknet ecosystem! I really want and I am motivated to start doing my first contributions to the ecosystem, I would be honored to tackle this issue by looking at what the result of this API is about and making all changes needed !

@barabanovro
Copy link
Contributor Author

Thank you everyone for your interest in working on this issue. I am assigning it to @melnikga, who has the capacity and relevant experience to address this promptly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants