Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open membership mechanism #52

Closed
Tracked by #70
chair28980 opened this issue Aug 24, 2023 · 6 comments
Closed
Tracked by #70

Open membership mechanism #52

chair28980 opened this issue Aug 24, 2023 · 6 comments
Assignees
Labels
E:3.2: Basic DoS protection in production See https://github.com/waku-org/pm/issues/70 for details

Comments

@chair28980
Copy link
Contributor

Mainnet contract (and instructions/guide) where anyone willing to pay the registration transaction fee can register a new membership, with membership limit set upfront. At this stage deployed RLN validators should build memberships off mainnet.

Priority: Critical for launch

@jm-clius jm-clius transferred this issue from waku-org/research Sep 1, 2023
@fryorcraken fryorcraken added this to the Waku Network Gen 0 milestone Sep 5, 2023
@fryorcraken fryorcraken added E:3.1: DoS requirements and design See https://github.com/waku-org/pm/issues/69 for details and removed E:2023-1mil-users labels Sep 8, 2023
@rymnc
Copy link

rymnc commented Sep 11, 2023

Please define the membership limit so that we can alter the contract's upper limit :)

@jm-clius jm-clius removed the E:3.1: DoS requirements and design See https://github.com/waku-org/pm/issues/69 for details label Sep 13, 2023
@chair28980
Copy link
Contributor Author

@jm-clius what should the membership limit be set to?

@jm-clius
Copy link

Please define the membership limit so that we can alter the contract's upper limit :)

I think we decided on 10000.

@fryorcraken
Copy link
Contributor

Pretty sure we agreed for mainnet later? Should we set a limit on Sepolia contract though? @jm-clius @rymnc

@jm-clius
Copy link

jm-clius commented Dec 5, 2023

Yes, this item is no longer critical for launch (we are parking mainnet deployment for a while), but it's probably a good idea to limit the number of memberships on the Sepolia contract @rymnc. Could we do this in a way that is upgradable in case we decide to change the limit (for whichever reason) as the network grows?

@rymnc
Copy link

rymnc commented Dec 5, 2023

Yes, this item is no longer critical for launch (we are parking mainnet deployment for a while), but it's probably a good idea to limit the number of memberships on the Sepolia contract @rymnc. Could we do this in a way that is upgradable in case we decide to change the limit (for whichever reason) as the network grows?

It already is, I can deploy a new storage with this limit and force transition if you'd like.

@chair28980 chair28980 added the E:3.2: Basic DoS protection in production See https://github.com/waku-org/pm/issues/70 for details label Jan 28, 2024
@chair28980 chair28980 removed this from the Waku Network Gen 0 milestone Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:3.2: Basic DoS protection in production See https://github.com/waku-org/pm/issues/70 for details
Projects
Status: Done
Development

No branches or pull requests

4 participants