New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore:pubsub topic && content_topic encoding is optional #3128

Open

AYAHASSAN287 opened this issue Oct 17, 2024 · 0 comments

AYAHASSAN287 commented Oct 17, 2024

Background

When calling API get /store/v3/messages with pubsubTopic encoded or not encoded it works

[...]

Details

ex :
curl -v -X GET "http://127.0.0.1:49153/store/v3/messages?includeData=true&pubsubTopic=/waku/2/rs/3/0&pageSize=20&ascending=true"

or call it encoded
ex:

curl -v -X GET "http://127.0.0.1:5213/store/v3/messages?includeData=true&pubsubTopic=%2Fwaku%2F2%2Frs%2F3%2F0&pageSize=20&ascending=true"

in both cases it works ang got the message with correct topic name

Acceptance criteria

According to specs pubsubtopic shall be encoded

so behavior and specs Don't match either specs shall mark the encoding as optional or SW change to mandatory

Note: same for content_topic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment