Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to the algorithms that will need their own PRs #613

Open
BigBlueHat opened this issue Aug 7, 2024 · 1 comment
Open

Changes to the algorithms that will need their own PRs #613

BigBlueHat opened this issue Aug 7, 2024 · 1 comment
Assignees

Comments

@BigBlueHat
Copy link
Member

Some of these assume changes to the algorithms that will need their own PRs:

  • Tests expand/er57 and er58 along with toRdf/er57 and er58 need a check to be sure that the value is an array, or generate the invalid set or list object error. The presumed semantics are that each array value becomes its own JSON value.
  • Test compact/ej01 is expected to raise multiple JSON literals because the term didn't use @set. This is arguably a breaking change as any data that did this before would now fail (of course two JSON values on input would now be one JSON value on output). This will certainly require checks in the compaction algorithm.
  • Test compact/js07 (and others) also change the behavior to preserve the array value.

Originally posted by @gkellogg in #559 (comment)

@TallTed
Copy link
Member

TallTed commented Aug 14, 2024

As discussed, this should probably be broken into at least one issue per bullet. Some might be "defer to 2.0".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Discuss-Call
Development

No branches or pull requests

4 participants
@BigBlueHat @davidlehn @TallTed and others