Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed tests for macos, and duplicate test file causing issues #258

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PatrickAlphaC
Copy link
Contributor

What I did

  1. Fixed test_value_error fails (on MacOS?) #256 by skipping tests if on macos. I'm not sure this is the solution, but if it is, then yay, here is the fix.
  2. Their were two files named test_logs which, when running raw pytest results in this error:
import file mismatch:
imported module 'test_logs' has this __file__ attribute:
  /path/code/titanoboa/tests/integration/fork/test_logs.py
which is not the same as the test file we want to collect:
  /path/code/titanoboa/tests/unitary/test_logs.py
HINT: remove __pycache__ / .pyc files and/or use a unique basename for your test file modules

So we just renamed one of them.

How I did it

  • Added a skipif to the test failing on macos
  • changed the name of one of the test files

How to verify it

  1. get on a macos and run: pytest tests/unitary/ and tests now pass
  2. Run pytest tests/unitary/test_logs.py tests/integration/fork/test_logs_weth.py and tests will pass the issue they ran into before. On the master branch, if you run pytest tests/unitary/test_logs.py tests/integration/fork/test_logs.py they will fail.

Description for the changelog

Cute Animal Picture

image

@PatrickAlphaC PatrickAlphaC changed the title fixed tests for macos fixed tests for macos, and duplicate test file causing issues Jul 19, 2024
@charles-cooper
Copy link
Member

let's not do the skipif thing, that's just a band-aid.

for the file conflict, i think the appropriate fix is to add an __init__.py file to each of the directories

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_value_error fails (on MacOS?)
2 participants