fix(runtime-dom): set text as an attribute for a tags
#12212
+13
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-sfc
@vue/compiler-ssr
@vue/runtime-dom
@vue/runtime-core
@vue/reactivity
@vue/server-renderer
@vue/shared
@vue/compat
vue
@vue/compiler-dom
commit: |
Justineo
reviewed
Oct 18, 2024
Comment on lines
+125
to
+128
| // #12211 <a text> must be set as attribute | ||
| if (key === 'text' && el.tagName === 'A') { | ||
| return false | ||
| } |
There was a problem hiding this comment.
<a> element doesn't have a text attribute while HTMLAnchorElement has a text property. Not sure if we should add this or should let users to use ^text="..." instead.
There was a problem hiding this comment.
I missed this detail, thanks for pointing it out.
There was a problem hiding this comment.
I'm not saying we shouldn't add this 😅
I just want to first discuss the criteria we use to handle such situations and whether we should first check if other frameworks have any special handling. I think we can keep this open for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #12211