Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temos algum motivo específico para o componente de textarea ter o estilo com max-width: 20rem? #1962

Open
viniciuslagedo opened this issue Sep 20, 2024 · 2 comments · May be fixed by #1981
Open

Temos algum motivo específico para o componente de textarea ter o estilo com max-width: 20rem? #1962

viniciuslagedo opened this issue Sep 20, 2024 · 2 comments · May be fixed by #1981
Labels
question Inquiries or questions about the project

Comments

@viniciuslagedo
Copy link
Contributor

How can we help?

Estamos implementando uma interface onde esse componente é full-width e reparamos que esse componente contém essa propriedade de max width. Consegui contornar o meu case aplicando um wrapper no componente e mudando via css modules. Mas fiquei em dúvida se ter essa max width é alguma boa prática de uso.

What have you tried?

No response

Additional information

No response
@viniciuslagedo viniciuslagedo added the question Inquiries or questions about the project label Sep 20, 2024
@davicostalf
Copy link
Contributor

@viniciuslagedo Discutimos essa issue ontem e provavelmente foi um erro mesmo. Podemos remover a propriedade.

@viniciuslagedo
Copy link
Contributor Author

Show! Vou abrir um PR então! 🚀

viniciuslagedo added a commit that referenced this issue Sep 27, 2024
@viniciuslagedo
fix(textarea): remove max width css prop
285d29e 
fix #1962
@viniciuslagedo viniciuslagedo linked a pull request Sep 27, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Inquiries or questions about the project
Projects
Shoreline
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(textarea): remove max-width css property vtex/shoreline
2 participants
@viniciuslagedo @davicostalf