Duplicate declaration: Package[gnupg] introduced with v2.0.0

[saz]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: 6.27.0
• Ruby: 2.7
• Distribution: Ubuntu
• Module version: 2.0.0

How to reproduce (e.g Puppet code you use)

Use apt and rvm at the same time

What are you seeing

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Duplicate declaration: Package[gnupg] is already declared at (file: /etc/puppetlabs/code/environments/production/modules/apt/manifests/init.pp, line: 372); cannot redeclare (file: /etc/puppetlabs/code/environments/production/modules/gnupg/manifests/install.pp, line: 4) (file: /etc/puppetlabs/code/environments/production/modules/gnupg/manifests/install.pp, line: 4, column: 3) on node some-host.example.com

What behaviour did you expect instead

Successful management of rvm

Any additional information you'd like to impart

The apt module uses ensure_packages(['gnupg']) while the gnupg module (introduced in 1c71b55) uses package { 'gnupg':... with some parameters.

Except for either fixing the gnupg module (which is outdated anyways - last release 2016) or getting rid of it, I don't have any idea how to properly fix this.

[saz]

Maybe dropping include gnupg (it's only installing the package) and adding ensure_packages(['gnupg']) might be an option?

But package name differs on e.g. Debian, RedHat and Suse, which the gnupg module handles properly.

[choffee]

The gnupg module it relies on has not been touched in many years. It might be good to move this into the module.

[choffee]

Ah looks like there is now an install_gnupg parmeter in the main branch which fixes it for me. Any chance of a release?

[ekohl]

The gnupg module it relies on has not been touched in many years. It might be good to move this into the module.

Agreed it's poorly maintained and needs attention. Right now it's blocking Puppet 8 support as well.

Maybe dropping include gnupg (it's only installing the package) and adding ensure_packages(['gnupg']) might be an option?

It does use more of the module:

puppet-rvm/manifests/system.pp

Lines 39 to 47 in 246434b

	gnupg_key { $key['id']:
	ensure => 'present',
	user => 'root',
	key_id => $key['id'],
	key_source => $key['source'],
	key_type => public,
	before => Exec['system-rvm'],
	require => $dep,
	}

I don't know if that could be easily replaced by something else.

[saz]

I've just suggested to drop the include gnupg part, as this isn't adding anything else, except the package.

Maybe https://forge.puppet.com/modules/h0tw1r3/gnupg/readme is a potential replacement?