Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number on cs_primitive parameter value causes repeat diffs #432

Open
icb- opened this issue Jan 12, 2018 · 0 comments
Open

Number on cs_primitive parameter value causes repeat diffs #432

icb- opened this issue Jan 12, 2018 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@icb-
Copy link

icb- commented Jan 12, 2018

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 4.10.9
  • Ruby: ruby 2.0.0p648 (2015-12-16) [x86_64-linux]
  • Distribution: CentOS 7.4
  • Module version: 6.0.0

How to reproduce (e.g Puppet code you use)

  cs_primitive { 'fence_one':
    primitive_class => 'stonith',
    primitive_type  => 'fence_ipmilan',
    parameters      => { 'pcmk_host_list' => 'one',
                         'delay'  => 15,
                         'ipaddr' => '192.168.0.180',
                         'login'  => 'admin',
                         'passwd' => '...',
                         'auth'   => 'MD5' },
    operations      => { 'monitor' => { 'interval' => '60s' } },
    cib             => 'puppet'
  }

What are you seeing

Every puppet run tries to change the cs_primitive's parameters, but then pcs kicks it out as having no change.

What behaviour did you expect instead

No change applied.

Output log

Notice: /Stage[main]/Openstack_cluster::Test/Cs_primitive[fence_one]/parameters: parameters changed {'auth' => 'MD5', 'delay' => '15', 'ipaddr' => '192.168.0.180', 'login' => 'admin', 'passwd' => '...', 'pcmk_host_list' => 'one'} to '{"pcmk_host_list"=>"one", "delay"=>15, "ipaddr"=>"192.168.0.180", "login"=>"admin", "passwd"=>"...", "auth"=>"MD5"}'
Info: /Stage[main]/Openstack_cluster::Test/Cs_primitive[fence_one]: Scheduling refresh of Cs_commit[puppet]
Error: /Stage[main]/Openstack_cluster::Test/Cs_commit[puppet]: Failed to call refresh: Execution of '/sbin/pcs cluster cib-push /opt/puppetlabs/puppet/cache/shadow.puppet diff-against=/opt/puppetlabs/puppet/cache/shadow.puppet.ori' returned 1: Error: The new CIB is the same as the original CIB, nothing to push.
Error: /Stage[main]/Openstack_cluster::Test/Cs_commit[puppet]: Execution of '/sbin/pcs cluster cib-push /opt/puppetlabs/puppet/cache/shadow.puppet diff-against=/opt/puppetlabs/puppet/cache/shadow.puppet.ori' returned 1: Error: The new CIB is the same as the original CIB, nothing to push.

Any additional information you'd like to impart

Quoting the 15 on the delay parameter to force it to be a string works as expected.

@juniorsysadmin juniorsysadmin added the bug Something isn't working label Jan 13, 2018
@btravouillon btravouillon self-assigned this Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants