Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent secretgen-controller secret injection. #583

Open
GrahamDumpleton opened this issue Sep 21, 2024 · 0 comments
Open

Prevent secretgen-controller secret injection. #583

GrahamDumpleton opened this issue Sep 21, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@GrahamDumpleton
Copy link
Collaborator

GrahamDumpleton commented Sep 21, 2024

Is your feature request related to a problem? Please describe.

The workshop namespace and session namespace, plus secondary session namespaces explicitly listed in the workshop definition, are protected against secret injection by Carvel secretgen-controller by adding to the namespaces the annotation:

secretgen.carvel.dev/excluded-from-wildcard-matching: ""

Any namespaces objects created via session.objects and environment.objects do not have this annotation applied.

This means a workshop could create namespaces via the objects list which could serve as an avenue for stealing cluster secrets injected into all namespaces.

Note that this injection is stopped because how secretgen-controller does this is arguably poor security, so Educates blocks it to avoid leaking of sensitive secrets to workshop users.

Describe the solution you'd like

The annotation should be added automatically to any namespaces created via session.objects and environment.objects.

Describe alternatives you've considered

No response

Additional information

No response

@GrahamDumpleton GrahamDumpleton added the enhancement New feature or request label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

1 participant