Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display a message with the number of detected workers before processing them #103

Closed
Angelmmiguel opened this issue Mar 7, 2023 · 0 comments · Fixed by #126
Closed

Display a message with the number of detected workers before processing them #103

Angelmmiguel opened this issue Mar 7, 2023 · 0 comments · Fixed by #126
Labels
🚀 enhancement New feature or request 👋 good first issue Good for newcomers

Comments

@Angelmmiguel
Copy link
Contributor

Is your feature request related to a problem? Please describe.

By default, wws looks for workers in the given path and any directory inside. In certain projects, you may have some extra folders like python venv or NodeJS modules. You don't want these folders to be processed and this will be covered by #47.

However, this issue is not easy to notice. As discussed in #101, the CLI just hangs while trying to load all the files in the given directory.

Describe the solution you'd like

To inform the user about this, we can add a new message before start processing the workers:

X files are identified as workers. Start processing them

This message will help to spot these issues as users will notice it when waiting for wws to process the workers.

Describe alternatives you've considered

No response

Additional context

No response
@Angelmmiguel Angelmmiguel added 🚀 enhancement New feature or request 👋 good first issue Good for newcomers labels Mar 7, 2023
@gibachan gibachan mentioned this issue Mar 11, 2023
Closed
@Angelmmiguel Angelmmiguel mentioned this issue May 8, 2023
Merged
assambar added a commit that referenced this issue May 26, 2023
@assambar
feat: #103 show number of routes before loading workers
0ea58b0 
```
$$ target/debug/wws . --ignore 'src/**/*' --ignore 'target/**/*' --ignore 'docs/**/*' --ignore 'crates/**/*' | ts

May 26 08:49:33 ⚙️  Loading routes from: .
May 26 08:49:35 ⏳ Loading workers from 14 routes...
May 26 08:50:13 ✅ Workers loaded in 38.128146575s.
...
```
assambar added a commit that referenced this issue May 26, 2023
@assambar
feat: #103 show number of routes before loading workers
6e1c192 
```
$$ target/debug/wws . --ignore 'src/**/*' --ignore 'target/**/*' --ignore 'docs/**/*' --ignore 'crates/**/*' | ts

May 26 08:49:33 ⚙️  Loading routes from: .
May 26 08:49:35 ⏳ Loading workers from 14 routes...
May 26 08:50:13 ✅ Workers loaded in 38.128146575s.
...
```
assambar added a commit that referenced this issue May 30, 2023
@assambar
feat: #103 show number of routes before loading workers
4de6bb3 
```
$$ target/debug/wws . --ignore 'src/**/*' --ignore 'target/**/*' --ignore 'docs/**/*' --ignore 'crates/**/*' | ts

May 26 08:49:33 ⚙️  Loading routes from: .
May 26 08:49:35 ⏳ Loading workers from 14 routes...
May 26 08:50:13 ✅ Workers loaded in 38.128146575s.
...
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🚀 enhancement New feature or request 👋 good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
1 participant
@Angelmmiguel