Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [Bug]Partybots don't properly focus marked targets #2406

Open
ShiyoKozuki opened this issue Jan 3, 2024 · 0 comments · May be fixed by #2426
Open

🐛 [Bug]Partybots don't properly focus marked targets #2406

ShiyoKozuki opened this issue Jan 3, 2024 · 0 comments · May be fixed by #2426
Labels
bug Something isn't working

Comments

@ShiyoKozuki
Copy link
Contributor

ShiyoKozuki commented Jan 3, 2024

🐛 Bug report

This code states they should focus marked targets in combat:
https://github.com/vmangos/core/blob/development/src/game/PlayerBots/PartyBotAI.cpp#L373
What they do is will focus the target of the party leader or whatever is hitting them or a target at random completely(?). Most of the time it seems to be the party leader's target upon first engage. They never switch targets until their current target is dead, but the code makes it look like they should change target and go to the marked target then stick on it the entire time in combat, but the don't.

Expected behavior

Mark a target, party bots focus it no matter what. Is not the the case.

Steps to reproduce

  1. Spawn a dps partybot
  2. mark a target
  3. engage something not the marked target
  4. watch as the bots not swap to the marked target until their first target is dead
  5. Profit

Version & Environment

Client Version: 1.12.1

Commit Hash: newest

OS Client: win10
OS Server: win10

Crashlog

  • None
@ShiyoKozuki ShiyoKozuki added the bug Something isn't working label Jan 3, 2024
@ShiyoKozuki ShiyoKozuki linked a pull request Jan 10, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant