Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename zone-create and zone-delete commands #81

Open
britneywright opened this issue Dec 4, 2019 · 2 comments
Open

rename zone-create and zone-delete commands #81

britneywright opened this issue Dec 4, 2019 · 2 comments

Comments

@britneywright
Copy link
Contributor

The zone-create and zone-delete commands are misleading. VinylDNS does not currently support creating zones, it only connects to existing zones. And zone-delete could be misunderstood as deleting the zone itself when it is only removing (abandoning) the zone from VinylDNS. zone-create should become zone-connect and zone-delete should become zone-abandon.

@mdb
Copy link
Collaborator

mdb commented Dec 16, 2019

@britneywright Thanks for this! While I agree with your concern, both vinyldns-cli -- as well as the underlying go-vinyldns methods it utilizes -- generally utilize the naming convention and language used by the VinylDNS docs themselves. In this case, the VinylDNS docs use the term "create:"

https://www.vinyldns.io/api/create-zone.html

Do you feel the language should be changed here in the CLI before it's changed in the VinylDNS docs? And before it's changed in the underlying go-vinyldns client package?

It's also worth considering that this introduces a breaking change that arguably warrants a major version bump. However, if we aspire to keep vinyldns-cli's major versioning inline with VinylDNS itself -- as @pauljamescleary once requested -- then perhaps this change should coincide with parallel changes across the VinylDNS docs and other tools. Thoughts?

@britneywright
Copy link
Contributor Author

This is just a placeholder acknowledging a user concern so it isn’t forgotten. The use case was specifically the CLI so I made the issue here for the user. No action is expected on this issue at this time. We’re in an exploratory state. We can label this issue accordingly if that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants