You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The zone-create and zone-delete commands are misleading. VinylDNS does not currently support creating zones, it only connects to existing zones. And zone-delete could be misunderstood as deleting the zone itself when it is only removing (abandoning) the zone from VinylDNS. zone-create should become zone-connect and zone-delete should become zone-abandon.
The text was updated successfully, but these errors were encountered:
@britneywright Thanks for this! While I agree with your concern, both vinyldns-cli -- as well as the underlying go-vinyldns methods it utilizes -- generally utilize the naming convention and language used by the VinylDNS docs themselves. In this case, the VinylDNS docs use the term "create:"
Do you feel the language should be changed here in the CLI before it's changed in the VinylDNS docs? And before it's changed in the underlying go-vinyldns client package?
It's also worth considering that this introduces a breaking change that arguably warrants a major version bump. However, if we aspire to keep vinyldns-cli's major versioning inline with VinylDNS itself -- as @pauljamescleary once requested -- then perhaps this change should coincide with parallel changes across the VinylDNS docs and other tools. Thoughts?
This is just a placeholder acknowledging a user concern so it isn’t forgotten. The use case was specifically the CLI so I made the issue here for the user. No action is expected on this issue at this time. We’re in an exploratory state. We can label this issue accordingly if that helps.
The
zone-create
andzone-delete
commands are misleading. VinylDNS does not currently support creating zones, it only connects to existing zones. Andzone-delete
could be misunderstood as deleting the zone itself when it is only removing (abandoning) the zone from VinylDNS.zone-create
should becomezone-connect
andzone-delete
should becomezone-abandon
.The text was updated successfully, but these errors were encountered: