Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display zone ACL rules on zone command #28

Open
mdb opened this issue Oct 12, 2018 · 3 comments
Open

Display zone ACL rules on zone command #28

mdb opened this issue Oct 12, 2018 · 3 comments
Labels
hacktoberfest Hacktoberfest good first issues help wanted Extra attention is needed

Comments

@mdb
Copy link
Collaborator

mdb commented Oct 12, 2018

Description

Currently, the zone command fails to display zone ACL rules

Steps to Reproduce

  1. vinyldns zone --zone-id 123
  2. Observe that there are no ACL rules listed

Expected behavior: [What you expect to happen]

It would be great to render ACL rules data.

Versions

master

@mdb mdb added help wanted Extra attention is needed hacktoberfest Hacktoberfest good first issues labels Oct 12, 2018
@carlism
Copy link
Contributor

carlism commented Oct 9, 2020

Perhaps this was implemented already? I am seeing ACL rules in the json output:

$ bin/vinyldns zone --zone-id "bfd031dc-2eb9cc20317e" | json_pp
{
   "name" : "thing.net.",
   "acl" : {
      "rules" : [
         {
            "userId" : "f888975b-7f2cc4e5cfa4",
            "accessLevel" : "Read",
            "recordTypes" : [
               "A",
               "CNAME"
            ]
         }
      ]
   },
   "account" : "system",
   "adminGroupId" : "1fa41b0f-f07f3735c83a",
   "email" : "[email protected]",
   "accessLevel" : "Delete",
   "id" : "bfd031dc-2eb9cc20317e",
   "latestSync" : "2019-04-11T17:11:42Z",
   "status" : "Active",
   "updated" : "2020-10-09T13:37:57Z",
   "created" : "2019-04-11T17:11:41Z"
}

@mdb
Copy link
Collaborator Author

mdb commented Oct 12, 2020

@carlism Thanks for chiming in! I believe the ACL rules are present in the JSON response from the VinylDNS API itself, though I don't believe the CLI prints such ACL rules when inspecting an individual zone via vinyldns zone --zone-id <THE ZONE ID>. I believe the implicated code is here: https://github.com/vinyldns/vinyldns-cli/blob/master/src/zones.go#L64-L68

@carlism
Copy link
Contributor

carlism commented Oct 12, 2020

I see, so specifically in table output format.
I'll see what I can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Hacktoberfest good first issues help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants