Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong version when using PHAR distribution #5399

Closed
julpar opened this issue Mar 15, 2021 · 4 comments · Fixed by #8770
Closed

Wrong version when using PHAR distribution #5399

julpar opened this issue Mar 15, 2021 · 4 comments · Fixed by #8770
Labels

Comments

@julpar
Copy link

julpar commented Mar 15, 2021

While using phar distribution generic dev branch is displayed as version number.

root@81907ae44f79:/var/www# psalm -v
Psalm 4.x-dev@

Same for baseline generation:

root@81907ae44f79:/var/www# grep psalm-version psalm-baseline.xml 
<files psalm-version="4.x-dev@">

p.s: bring this topic here from an issue in repo psalm/phar bc it seems that repo is not where the discussion takes place, right? (psalm/phar#7)

@psalm-github-bot
Copy link

Hey @julpar, can you reproduce the issue on https://psalm.dev ?

@weirdan weirdan added the bug label Mar 15, 2021
@llaville
Copy link
Contributor

llaville commented Nov 9, 2021

It's very difficult to know in this condition if we have the latest version or not !

@llaville
Copy link
Contributor

llaville commented Nov 9, 2021

Another case where version is displayed as a pattern is in SARIF report (used psalm 4.12.0) :

{
    "version": "2.1.0",
    "$schema": "https:\/\/json.schemastore.org\/sarif-2.1.0.json",
    "runs": [
        {
            "tool": {
                "driver": {
                    "name": "Psalm",
                    "informationUri": "https:\/\/psalm.dev",
                    "version": "4.x-dev@"
                }
            },
            "results": []
        }
    ]
}

@villfa
Copy link
Contributor

villfa commented Jan 2, 2022

I have the same issue than OP. After digging a bit I think it's related to this: box-project/box#460

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants