Minimum Log Levels #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiosalvatore
force-pushed
the
min-log-levels
branch
2 times, most recently
from
dccd3a7
to
96957cc
Compare
leveled/logger.go
Outdated
| type defaultLogger struct { | ||
| *alog.Logger | ||
|
|
||
| // Indicates the minimum level to log at. If MinLevel is greater than the | ||
| // leve of a given log message, the log message will be suppressed. |
leveled/logger.go
Outdated
| @@ -39,32 +65,50 @@ func Default(logger *alog.Logger) Logger { | |||
| } | |||
| } | |||
|
|
|||
| // Filtered returns an advanced logger that allows for setting the minimum | |||
There was a problem hiding this comment.
don't need "advanced"
sergiosalvatore
force-pushed
the
min-log-levels
branch
from
96957cc
to
317c2a1
Compare
In the case of leveled logging, allow the user to set a minimum log level via the leveled.FilteredLogger type or through the gkelog.WithMinSeverity function which pipes it through the context. This allows us to suppress logs that are lower than the minimum level.
sergiosalvatore
force-pushed
the
min-log-levels
branch
from
317c2a1
to
4384b86
Compare
justinruggles
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of leveled logging, allow the user to set a minimum log level via the
leveled.FilteredLoggertype or through thegkelog.WithMinSeverityfunction which pipes it through the context.This allows us to suppress logs that are lower than the minimum level.