-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSL Exception not handled by OnError #39
Comments
manish-panwar
pushed a commit
to manish-panwar/mod-rxvertx
that referenced
this issue
Jun 16, 2015
hi manish, sorry for not responding to this sooner. the problem is that i think the proper change would require a core fix. you could at least mitigate the impact by ensuring you have a timeout on all requests and log any client level errors. -peter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey Guys,
I am connecting to a server with self-signed cert on SSL, which causes SSL Handshake Exception.
In a vertx world, javax.net.ssl.SSLHandshakeException are handled by the exception handler attached to "HttpClient", not by the exception handler that's attached to "HttpClientRequest". I am proposing following change in RxHttpClient to handle it.
this.core.exceptionHandler(new Handler() {
@OverRide
public void handle(Throwable event) {
rh.fail(event);
}
});
The text was updated successfully, but these errors were encountered: