Replies: 11 comments
-
@rauchg do you want to trigger a full process reload or a HMR? |
Beta Was this translation helpful? Give feedback.
-
HMR. I suspect it should already trigger but maybe it doesn't ? Maybe cause it's non-js |
Beta Was this translation helpful? Give feedback.
-
I think the same remark applies to |
Beta Was this translation helpful? Give feedback.
-
@sedubois I think we watch |
Beta Was this translation helpful? Give feedback.
-
@arunoda ok maybe, but as a user I don't see any message that changes in next.config.js are taken into account. |
Beta Was this translation helpful? Give feedback.
-
@arunoda @sedubois We do reload the server, also, it should show a message. https://github.com/zeit/next.js/blob/master/bin/next#L71-L81 Edit: just tested. It does show a message when reloading |
Beta Was this translation helpful? Give feedback.
-
@timneutkens I don't see that behaviour. When I change some text in Don't know if it matters, but I run with |
Beta Was this translation helpful? Give feedback.
-
It's using |
Beta Was this translation helpful? Give feedback.
-
OK, makes sense. |
Beta Was this translation helpful? Give feedback.
-
New thought: yarn.lock deltas actually give us awesome information about what has changed, and we can invalidate the portions of the tree that are affected. For example, if you have page |
Beta Was this translation helpful? Give feedback.
-
Looks like create-react-app does it this way: https://github.com/facebook/create-react-app/blob/next/packages/react-dev-utils/WatchMissingNodeModulesPlugin.js |
Beta Was this translation helpful? Give feedback.
-
Not sure if we're ignoring it right now, but I've noticed that after running
yarn
, reloading is not triggered.I think a smart shortcut to do that would be to detect
yarn.lock
having changedBeta Was this translation helpful? Give feedback.
All reactions