Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samsung Fridge TP1X_REF_21K - Unavaliable and missing temperature entities #81

Open
Csontikka opened this issue Jul 20, 2023 · 15 comments

Comments

@Csontikka
Copy link

Hello!

temp sensors are not coming up from the fridge. From the freezer and the cooler components.

Screenshot From HA:
image

Json of the components to debug:

TP1X_REF_21K - component json.txt

Structure:
image
image

Thanks for your help!

Regards,
Csontikka

@Csontikka Csontikka changed the title Samsung Fridge TP1X_REF_21K - no temp information Samsung Fridge TP1X_REF_21K - Unavaliable and missing temperature entities Jul 20, 2023
@Mark612
Copy link

Mark612 commented Jul 31, 2023

Same issue.

cgraf added a commit to cgraf/smartthings that referenced this issue Aug 10, 2023
@cgraf
Copy link

cgraf commented Aug 10, 2023

Doesn't seem like this is being super-maintained right now. I forked and created a PR to merge support for this model back into master. Just four very simple file changes. Feel free to review and manually replace in config/custom_components/smartthings if you are satisfied with the changes.

image

@blair287
Copy link

Doesn't seem like this is being super-maintained right now. I forked and created a PR to merge support for this model back into master. Just four very simple file changes. Feel free to review and manually replace in config/custom_components/smartthings if you are satisfied with the changes.

image

Done these changes seem temp is now working although cooler is 1 degree out from what smartthings says but my cooler and freezer door sensor dont work only the overall one is working any ideas?

@cgraf
Copy link

cgraf commented Aug 24, 2023

By "don't work" do you mean that they show as unavailable or only ever show closed or don't show up at all?

@blair287
Copy link

By "don't work" do you mean that they show as unavailable or only ever show closed or don't show up at all?

They show up they just show as closed all the time and never change state.

@cgraf
Copy link

cgraf commented Aug 25, 2023

Thanks. I'm a little embarrassed. I just saw that they were list as "Closed" and did not do the QA. Upon closer examination, mine don't work either. Odd that they would be surfaced with a default value, but can't be triggered. The "Contact" sensor should still work. Breaking the contact sensors into 4 doors will need further testing or may be a permanent limitation with this model. Sorry about that.

@itsgiff
Copy link

itsgiff commented Aug 29, 2023

are you folks close on getting this merged and resolved? sounds like you are close.

@cgraf
Copy link

cgraf commented Aug 29, 2023

@itsgiff I don't know that it will ever get merged. There's another PR awaiting merge from January this year. I think this repo may no longer be maintained.

@itsgiff
Copy link

itsgiff commented Aug 29, 2023

that is unfortunate

@veista
Copy link
Owner

veista commented Aug 29, 2023

View discussions please. It's not that I don't want to maintain this, it's just that the code in this repo is not maintainable! I fix one problem and 3 new ones pop up.

@veista
Copy link
Owner

veista commented Aug 29, 2023

So the easiest way to make it work for you is to fork this and make your changes there.

@cgraf
Copy link

cgraf commented Aug 29, 2023

That's what I did. I contributed it back to try to help some other folks having the same issue as me. The fork is sitting in PR along with another one which show no merge conflicts.

@itsgiff
Copy link

itsgiff commented Aug 29, 2023

I am not bright enough to update is myself. I will try @cgraf 's fork and see what happens. Thanks

@yolani
Copy link

yolani commented Sep 20, 2023

@cgraf I just tried your fork and sadly for my family hub fridge I still get no temperature readings. You want some logs to look into it?

@cgraf
Copy link

cgraf commented Sep 20, 2023

I'm not sure I can help too much. Do you know your mode actual model number? If it is TP1X_REF_21K, it should work, but all I did was add a precise match for this model to some existing logic. Do you have errors in the logs? Did your SmartThings device card change at all?

SoulGit added a commit to SoulGit/smartthings that referenced this issue Dec 15, 2023
cgraf added a commit to cgraf/smartthings that referenced this issue Aug 5, 2024
Fixes recent deprecation warnings and includes addition of model from veista#81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants