Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and update existing agents #444

Open
cdummett opened this issue Jul 10, 2023 · 0 comments
Open

Review and update existing agents #444

cdummett opened this issue Jul 10, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@cdummett
Copy link
Collaborator

cdummett commented Jul 10, 2023

Summary

Ticket is to review the structure of the Agent class and organise child classes into categories.

Updating agents

Properties which are standard to every Agent, AgentWithWallet, and StateAgentWithWallet need to be reviewed.

Categorising agents

Currently Agents are spread out though-out the code-base with the majority in vega_sim/scenario/common.py.

To improve readability, agents should be split into the following categories:

  • LiquidityProviders
  • MarketMakers
  • Traders
  • Snitches

Each category will have a separate file within an agents dir and its own class (inhering from Agent) with common properties / abstract methods for that agent category.

Updating agents should have considerations for future core features; e.g. successors, perps, and spots.

Stretch Goal

Should some agent parameters allow a list instead of a single value. Would make it easy to modify agents to exhibit behavior which varies with time rather than creating a whole new agent.

e.g. we want to gradually increase trade volume on the market, pass a list of order_size to a MarketOrderTrader rather than a fixed order_size.

@cdummett cdummett added the enhancement New feature or request label Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant