AMM first incentive snags

[JonRay15]

The Chore

Placeholder for observations from the first incentive.

Tasks

Pools

• The price has wrong decimals ... I can see 4 on BTC when it shoudl be 1
• Think we need to add Total liquidity as a column after all

Market details

• The BTC market is showing no commitments, this is wrong. See AMM API and you can see if we're filtering for active or reduce only commitments we should see volume. Note by the time we fix this the Core may have added a "Active only" flag to this API as we requested it
• We are showing settlement asset a lot ... can we show it once somewhere so we dont have to repeat?
• Too many decimals on fees .... lets use quantum formattig
• Too many decimals on liquidity committed (both types) ... lets use the K / M / B format function
• May be linked to the above but I still see "Add liquidity" even though I have some ... should see "Manage liquidity"

Add / Amend liquidity

• Again could be because we're not querying properly for active AMMs ... but when I go through to mine the values are not always prepopulated with the details of my active commitment. Most commonly I see teh slippage tolerance is missing ... but another time the fee was .... and sometimes it all is!
• Need a section at the top that shows
  • My liquidity, which can be blank if you havent submitted any, ignore the % change in teh sketch
  • Mark price of the market
• The new TX flow is a bit dodgy
  • its showing me that its confirmed while Im submitting (see pictre)
  • Then its showing me both are now ticked ...but the format of the ticks is weird, the circle is gone
  • then i hit dismiss but it doesnt actually disappear until I hit X again
• Cant verify if cancel is working because I cant tell I've got an active commitment, but in theory I'd expect to see it here and be able to cancel

Additional details / background info

TC flow

Then you confirm

Then you dismiss

And I have to then hit X

Decimals

{
  "submitAmm": {
    "marketId": "07d83b233cc0c43b8e46b5384bbbb52bd23d27502c20ba180cfb9c690e0ba6be",
    "commitmentAmount": "4000000000",
    "slippageTolerance": "0.04",
    "concentratedLiquidityParameters": {
      "upperBound": "62000000000",
      "lowerBound": "56000000000",
      "base": "59000000000",
      "leverageAtUpperBound": "10000000",
      "leverageAtLowerBound": "10000000"
    },
    "proposedFee": "0.0001"
  }
}