Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(RFC55): MembershipUpdateMessage protobuf #73

Open
2 tasks
jimstir opened this issue Jun 14, 2024 · 0 comments
Open
2 tasks

update(RFC55): MembershipUpdateMessage protobuf #73

jimstir opened this issue Jun 14, 2024 · 0 comments

Comments

@jimstir
Copy link
Collaborator

jimstir commented Jun 14, 2024

Reference issue: vacp2p/rfc#593
Author: kaiserd

background

This issue tracks an update to MembershipUpdateMessage that has been left for post-MVP.
previous discussion.

description

The field repeated bytes events = 2; of MembershipUpdateEventshould be of typeMembershipUpdateEvent. (Currently the first element is the signature, and all other elements after are encoded MembershipUpdateEvent`s.)
This requires adding a new field for the signature.

actions

  • add new field for signature
  • change type of events to MembershipUpdateEvent

cc @rymnc @felicio
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jimstir